Grrr ... find the humor ...

[Baker]

This is in the Kurok PSP source, not surprisingly ... it doesn't actually work. But I didn't notice and was wondering why the KurokPSP wasn't doing what I expected.

Code: Select all

  // Tomaz - QC Alpha Scale Glow Begin

    {
        eval_t  *val;

        alpha=1;
        scale=1;

        if (val == GetEdictFieldValue(ent, "alpha"))
        {
            alpha = val->_float;
        }
        else
            alpha = 1;

        if (val == GetEdictFieldValue(ent, "scale"))
        {
            scale = val->_float;
        }
        else
            scale = 1;

        if (scale > 4)
            scale = 4;
.
.
.
    }

    // Tomaz - QC Alpha Scale Glow End

[Spike]

well it fixes one warning, at least.

[Spirit]

Missing {} for the last if? I am guessing wildly, QuakeC's rules confuse me since I never really did anything in it.

[Spike]

Its C, not C++, and {} works the same way - not needed if it would contain a single line (or rather a single semi-colon.... unless its a control statement in which case its allowed multiple... you know what, I'm just gonna shut up now).

Have another go. :)

[frag.machine]

Just took a quick look, but looks like nobody is initializing val before it's being referenced, correct ?

[qbism]

Didn't see alpha or scale declared. Also, if it's wrong, let it be wrong more efficiently:

Code: Select all

  // Tomaz - QC Alpha Scale Glow Begin

    {
        eval_t  *val;

        alpha=1;
        scale=1;

        if (val == GetEdictFieldValue(ent, "alpha"))
              alpha =val->_float;

        if (val == GetEdictFieldValue(ent, "scale"))
       {
            scale = val->_float;
            if (scale > 4)
            scale = 4;
        }

.
.
.
    }

    // Tomaz - QC Alpha Scale Glow End

Maybe check alpha >=0 and <=1? Check scale >0?

[frag.machine]

The compiler would complain about undeclared vars, but it may fail to detect references to a non-initialized pointer. Anyway, this comes exactly to reforce my point: people should at least try to understand what they're doing when doing Ctrl+C/Ctrl+V. It's very likely that someone pasted that at some point, the change obviously didn't work, and he/she didn't bother to revert things. :/

[metlslime]

== should be =

[mh]

== should be =

Dammit you're right. I've been scratching my head over that one!

Probably intended to be something like this:

Code: Select all

if ((val = GetEdictFieldValue(ent, "alpha")) != NULL)

[qbism]

Looks so obvious now.
[facepalm] Picard [/facepalm] good catch!

[Baker]

I thought I need a custom protocol to integrate true Kurok support the way the author presented it!

I don't.

It was never working to begin with. Yeah, Spike obviously nailed it on reply #1 with Metlslime saying the answer, but I actually "fixed" the code with = and got endless crashes not realizing I had "fixed" what had never been operational.

So tasks -1. Kurok was not using a custom protocol on the PSP.