free(*ptr) problems with Windows7

[r00k]

Windows 7 keeps crashing if i use free(ptr) in some instances where in Win XP it doesnt

here's what i have replaced free with that works on both OS's but not sure if it's proper to use memset instead of free?

Code: Select all

         if ((cls.download.error)||(success == FALSE))
            {
               Con_Printf ("Download Error: %s\n",cls.download.error);
               Con_Printf ("\nThe required file '%s' could not be found at %s.\n", model_precache[i], url);
               remove (download_tempname);
               memset (download_tempname, 0, sizeof(download_tempname));
               memset (download_finalname, 0, sizeof(download_finalname));
               memset (url, 0, sizeof(url));
               memset (name, 0, sizeof(name));
               memset (folder, 0, sizeof(folder));
               return;
            }            


[frag.machine]

memset () doesn't free the pointer, you're just clearing the memory it points - and not in a very legible way, since we cannot infer how much of the heap the variables passed as arguments to sizeof() are using.

[Spike]

memory allocated with malloc must be freed within the same module that malloced it.
Failing that, you must ensure that the version of the CRT matches exactly.
Which it probably doesn't.

[mh]

From looking at your code, you've got char download_tempname[MAX_QPATH] at the start of your loop. There's no need to free a static array, so the Windows 7 behaviour is actually correct, if a little less forgiving.

[r00k]

Opps! was thinking they were static arrays, I guess i had revised and changed the variable declarations...
thanks to all for clarifying things