Fixing the `bug` in E4M8 (The Nameless City)

[dayfive]

right at the beginning of the nameless city if you stand on the top of the teleporter, it results in a program error....

how to best go about fixing this using QuakeC?

[DieparBaby]

At the beginning of teleport_touch() in triggers.qc just after this:

Code: Select all

local entity t;
local vector org;


put this:

Code: Select all

t = find( world, targetname, self.target );
if( !t )
{
    if( mapname == "e4m8" )
    {
        return;
    }
    objerror( "couldn't find target" );
}

[dayfive]

At the beginning of teleport_touch() in triggers.qc just after this:

Code: Select all

local entity t;
local vector org;


put this:

Code: Select all

t = find( world, targetname, self.target );
if( !t )
{
    if( mapname == "e4m8" )
    {
        return;
    }
    objerror( "couldn't find target" );
}

thanks!

[Dr. Shadowborg]

That's good, but unfortunatly, it'll have an unfortunate side effect of not removing the trigger. In short, you'll get a constantly repeating teleport flash / fog effect whenever you're touching it.

It's probably better to put:

Code: Select all

if(mapname == "e4m8" && self.target == "t273")
{
  remove(self);
  return;
}


This will cause the trigger_teleport to be removed upon spawning when the level loads.

And no, I did not look at the map sources to determine the target designation. You can use this to good effect to hack and change a lot of entities and conditions for activating said entities by learning to use the data they contain to identify them. (One very good example is patrick martin's dragons! patch.)

[DieparBaby]

Actually if you put that code right at the beginning of the touch function like I indicated
you won't get the teleport flash. I tested it in game. The code will only
return if the teleport doesn't have a target so other valid teleports on e4m8 are fine.

[Dr. Shadowborg]

Actually if you put that code right at the beginning of the touch function like I indicated
you won't get the teleport flash. I tested it in game. The code will only
return if the teleport doesn't have a target so other valid teleports on e4m8 are fine.

Then you'll be calling a horribly ineffecient find function twice, unless you take out the one that's called later on. =P

Incidentally, I forgot to mention that the code bit I posted should be placed at the beginning of the trigger_teleport function.

[Lardarse]

I like the idea of what you're trying to do, but it's far easier to remove the entity in question. The hardest part is just to work out how to uniquely identify the entity you want to change/remove, and for that, a combination of looking at the map sources, looking at a list of just the entities in the map (do sv_saveentfile from within DarkPlaces), or creating a progs.dat that helps you to identify things from a players-eye view will help you to determine what needs to be changed.

[FrikaC]

You could just use the fixes found on QIP

[dayfive]

to be perfectly honest, i kind of like the repeating teleport fog/flash whatever.... so the first solution is fairly nice imho

however, this solution has implications reaching far beyond this small problem; which i will most definitely note for future reference

Code: Select all

if(mapname == "e4m8" && self.target == "t273")
{
  remove(self);
  return;
}


also, i couldn't find any mention of the e4m8 bug

You could just use the fixes found on QIP

on at least the following URLs

http://www.inside3d.com/qip/q1/bugs.htm
http://www.inside3d.com/qip/q1/qcfix.htm
http://www.inside3d.com/qip/q1/qfix.htm

where is this specific issue talked about on QIP?

[FrikaC]

That's because all of those links go to code related bugs or fixes, it's a map error and is thus found on the Map bugs section:

http://www.inside3d.com/qip/q1/bugsmap.htm#Maps

The text of the problem is this:

"Quake crashes on E4M5, when a player grapples, noclips or rocket/grenade-jumps to the top of the secret exit.
Reported by Robert "Frog" Field
A similar error occurs in the START map under the exit to the end level (by Robert Field too) and at top of the start gate in E4M8 (by Max Bartlett)"

It links to this QuakeC fix as well as patches for the actual maps.

[dayfive]

That's because all of those links go to code related bugs or fixes, it's a map error and is thus found on the Map bugs section:

http://www.inside3d.com/qip/q1/bugsmap.htm#Maps

The text of the problem is this:

"Quake crashes on E4M5, when a player grapples, noclips or rocket/grenade-jumps to the top of the secret exit.
Reported by Robert "Frog" Field
A similar error occurs in the START map under the exit to the end level (by Robert Field too) and at top of the start gate in E4M8 (by Max Bartlett)"

It links to this QuakeC fix as well as patches for the actual maps.

oh!! I see now.... Thanks for pointing this out!

it's good to know about those others as well! In those cases it might be more desirable to use the if(mapname == "whatever" && self.target == "t420") remove(self); fix

thanks for describing it in detail

[Lardarse]

In those cases it might be more desirable to use the if(mapname == "whatever" && self.target == "t420") remove(self); fix

I think it's the better fix to use, unless you're going to be using modified maps.